Merged
Conversation
mikix
force-pushed
the
mikix/old-mongo-not-marketable
branch
3 times, most recently
from
4536668 to
ed8bb72
Compare
mikix
commented
Mar 1, 2022
| self.client.force_authenticate(self.user) | ||
| self.course = CourseFactory(partner=self.partner, key='simple_key') | ||
| self.course_run = CourseRunFactory(course=self.course) | ||
| self.course_run = CourseRunFactory(course=self.course, key='simple/key/run') |
Contributor
Author
There was a problem hiding this comment.
I tried but failed to figure out how to properly escape a modern-style key for elasticsearch (presumably have to encode the colon and plus somehow), so I just used an old-style key instead. The point of the test is whether we can pass the key around, not the encoding specifically, so I just called it a day. No worse than before anyway.
mikix
commented
Mar 3, 2022
Comment on lines
+1986
to
+1988
| if CourseKey.from_string(self.key).deprecated: # Old Mongo courses are not marketed | ||
| return False |
Contributor
Author
There was a problem hiding this comment.
This is the actual point of this PR - rest is test fixes to accomodate this.
mikix
force-pushed
the
mikix/old-mongo-not-marketable
branch
from
ed8bb72 to
38bee67
Compare
waheedahmed
approved these changes
Mar 8, 2022
They are being sunset and we no longer want to link to them. DEPR-58
mikix
force-pushed
the
mikix/old-mongo-not-marketable
branch
from
38bee67 to
1c60c01
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are being sunset and we no longer want to link to them.
Because I started paying attention to key structure, I also updated the default course factories to use new-style keys and updated some tests to match.
(My first swing at this was on the LMS side to mark them
hidden, but prospectus still generates pages for those courses, just doesn't include them in search/browse results. So this is a step further.)DEPR-58